-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: fix up compatibility with a Qwik typescript version #7617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 022ed47 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the latest versions of this packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help @FDiskas 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, maybe we should remove this integration.
There's https://github.com/wmertens/compiled-i18n which does an extremely similar thing but more integrated, and https://github.com/robisim74/qwik-speak which is more focused on runtime translations.
Not really because core typescript version is older than angular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really because core typescript version is older than angular
I see, thanks 👍
I see, let's create another PR for that. |
We will address your feedback in a separate PR.
What is it?
Description
Currently, it is impossible to install
Integration: i18n $localize (compile time translations)
Checklist
pnpm change