Skip to content

Conversation

FDiskas
Copy link
Contributor

@FDiskas FDiskas commented May 19, 2025

What is it?

  • Bug

Description

Currently, it is impossible to install Integration: i18n $localize (compile time translations)

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: my-qwik-basic-starter@undefined
npm error Found: [email protected]

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@FDiskas FDiskas requested a review from a team as a code owner May 19, 2025 23:17
Copy link

changeset-bot bot commented May 19, 2025

🦋 Changeset detected

Latest commit: 022ed47

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented May 19, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7617
npm i https://pkg.pr.new/@builder.io/qwik-city@7617
npm i https://pkg.pr.new/eslint-plugin-qwik@7617
npm i https://pkg.pr.new/create-qwik@7617

commit: 900c64d

Copy link
Contributor

github-actions bot commented May 19, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 900c64d

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the latest versions of this packages?

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @FDiskas 👏

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe we should remove this integration.

There's https://github.com/wmertens/compiled-i18n which does an extremely similar thing but more integrated, and https://github.com/robisim74/qwik-speak which is more focused on runtime translations.

@FDiskas
Copy link
Contributor Author

FDiskas commented May 20, 2025

Thanks for your help @FDiskas 👏

Not really because core typescript version is older than angular

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really because core typescript version is older than angular

I see, thanks 👍

@gioboa gioboa requested a review from wmertens May 20, 2025 09:49
@gioboa
Copy link
Member

gioboa commented May 20, 2025

Actually, maybe we should remove this integration.

There's https://github.com/wmertens/compiled-i18n which does an extremely similar thing but more integrated, and https://github.com/robisim74/qwik-speak which is more focused on runtime translations.

I see, let's create another PR for that.

gioboa
gioboa previously approved these changes Jul 29, 2025
@gioboa gioboa changed the title Compatibility with a qwik typescript version fix: compatibility with a Qwik typescript version Jul 29, 2025
@gioboa gioboa changed the title fix: compatibility with a Qwik typescript version fix: fix up compatibility with a Qwik typescript version Jul 29, 2025
@gioboa gioboa dismissed wmertens’s stale review July 29, 2025 16:04

We will address your feedback in a separate PR.

@gioboa gioboa enabled auto-merge (squash) July 29, 2025 16:07
@gioboa gioboa merged commit 93c0c51 into QwikDev:main Jul 29, 2025
34 of 36 checks passed
@FDiskas FDiskas deleted the patch-3 branch July 30, 2025 10:45
@github-actions github-actions bot mentioned this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants